> On Feb. 1, 2018, 7:46 a.m., Greg Mann wrote: > > src/tests/api_tests.cpp > > Lines 6349-6352 (patched) > > <https://reviews.apache.org/r/65044/diff/8/?file=1946620#file1946620line6350> > > > > Are these necessary? I think that framework registration may be > > sufficient to produce an offer?
`settle` isn't necessary, but `advance` is, see the similar comment in #65045. - Jan ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65044/#review196620 ----------------------------------------------------------- On Feb. 2, 2018, 2:21 p.m., Jan Schlicht wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65044/ > ----------------------------------------------------------- > > (Updated Feb. 2, 2018, 2:21 p.m.) > > > Review request for mesos, Benjamin Bannier, Gaston Kleiman, Greg Mann, Jie > Yu, and Vinod Kone. > > > Bugs: MESOS-8424 > https://issues.apache.org/jira/browse/MESOS-8424 > > > Repository: mesos > > > Description > ------- > > The 'GET_OPERATIONS' call lists all operations known to master or agent. > > > Diffs > ----- > > include/mesos/agent/agent.proto 315820041990d28e5cdae71c8385d4551d56558c > include/mesos/master/master.proto 3e34634f3b864222d07374936c0d9a18269c2fbd > include/mesos/v1/agent/agent.proto 9e8b49defb83ffd4dd240ebb3a09b2dd3610ab2a > include/mesos/v1/master/master.proto > 6759c3004e7e04c0044360b0c54f4438c2f6ec8a > src/master/http.cpp c489b6f525f157811549b2cc84addd9d85e87990 > src/master/master.hpp b434d2398b8815811345b6586ca586d2025cb2a2 > src/master/validation.cpp f0b86775b7919ba6aa4a73038edb78a0adca68f4 > src/slave/http.hpp 1619bb77e3e7d5a6d387e4d4bb071d83ce914967 > src/slave/http.cpp 77e711ceeb0e2613d629b5e21fd686f85dfad11a > src/slave/validation.cpp 0c2ccda177734cf3c47c0346ed34d20d58e7d932 > src/tests/api_tests.cpp b639a4bafbf69d3ea53aa0573e9f0489c3a1a57f > > > Diff: https://reviews.apache.org/r/65044/diff/9/ > > > Testing > ------- > > make check > > > Thanks, > > Jan Schlicht > >
