> On Oct. 31, 2017, 1:53 a.m., Benjamin Mahler wrote: > > 3rdparty/libprocess/include/process/memory_profiler.hpp > > Lines 56-62 (patched) > > <https://reviews.apache.org/r/63368/diff/1/?file=1870336#file1870336line56> > > > > When I read 'dump' I think it will write some things to output or > > files, not returning an object that contains data (maybe this is just me?). > > Ditto above.
Renamed to 'downloadXXX'. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63368/#review189680 ----------------------------------------------------------- On Oct. 27, 2017, 7:04 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63368/ > ----------------------------------------------------------- > > (Updated Oct. 27, 2017, 7:04 p.m.) > > > Review request for mesos, Alexander Rukletsov and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > This class exposes profiling functionality of jemalloc memory allocator > when it is detected to be the memory allocator of the current process. > > In particular, it gives developers an easy method to collect and > access heap profiles which report which pieces of code were > responsible for allocating memory. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am ba9e78148932304ce1961b88e5f97180abd35586 > 3rdparty/libprocess/include/process/memory_profiler.hpp PRE-CREATION > 3rdparty/libprocess/include/process/process.hpp > 8b8323f5fb4617aa9c22bbdb56af3d1cb0b06ea3 > 3rdparty/libprocess/src/memory_profiler.cpp PRE-CREATION > 3rdparty/libprocess/src/process.cpp > 2126c272a69bfa53b4b3cbbb1a55a3f81a5da8ad > > > Diff: https://reviews.apache.org/r/63368/diff/2/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
