----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65395/#review197366 -----------------------------------------------------------
I like what I see. Just a few little things to discuss. src/checks/checker_process.cpp Lines 210-211 (patched) <https://reviews.apache.org/r/65395/#comment277505> For future reference, you can usually replace this with a `UNREACHABLE()`. src/checks/checker_process.cpp Line 217 (original), 232-235 (patched) <https://reviews.apache.org/r/65395/#comment277504> Why not move the body of the `checkInfoToCheck` helper into the constructor? It doesn't see like it is used anywhere else. It is better to justify a `LOG(FATAL)` like this: ``` case CheckInfo::UNKNOWN: { // TODO(josephw): Add validation at the agent or master level. // Without validation, this is considered a mis-configuration of the task (user error). LOG(FATAL) << "Received UNKNOWN check type"; } ``` You may also be able to remove the `Try<>` portion of the `check` object if you construct it here. src/checks/checker_process.cpp Lines 283-284 (patched) <https://reviews.apache.org/r/65395/#comment277507> Looks like the last `+` to the left of `TCP` is not aligned :D src/checks/checker_process.cpp Lines 297-298 (patched) <https://reviews.apache.org/r/65395/#comment277508> I believe it won't be too difficult to get nested containers working on Windows (no images, just nested job objects). If we can enable the tests under `agent_container_api_tests.cpp`, that should give sufficient confidence that nested containers work. There are separate tests for health checks that can be enabled later (like ` HealthCheckTest.DefaultExecutorCommandHealthCheck`). - Joseph Wu On Feb. 8, 2018, 9:49 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65395/ > ----------------------------------------------------------- > > (Updated Feb. 8, 2018, 9:49 a.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and > Gaston Kleiman. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > Refactored health check code to separate the logic for each check > type and runtime (Plain/Docker/Nested). Now the matrix of different > possiblilites is cleanly enumerated, making it easier to add > future health checks, such as the ones for Windows. > > > Diffs > ----- > > src/checks/checker.hpp 93502270f31e80c5f7c94b5b456625e9cdea1837 > src/checks/checker.cpp fff0aac504b4283a210f936e00c977fa60d88b3d > src/checks/checker_process.hpp 510f3b2e6e689faaf26595214ce377c2b5518f28 > src/checks/checker_process.cpp ddb197b8cc2c503fef5ae20af32f5881fff9833f > src/checks/health_checker.hpp 019fbd791f250ecc28ff59d779f90e7ccbf0c685 > src/checks/health_checker.cpp eaf9a18817eeeff7c29c7a4b9d1b183f398760a3 > src/docker/executor.cpp e4c53d558e414e50b1c429fba8e31e504c63744a > src/launcher/default_executor.cpp 4a619859095cc2d30f4806813f64a2e48c83b3ea > src/launcher/executor.cpp 164ecc7ba51f75db6ec581aa4b135526c304dd00 > > > Diff: https://reviews.apache.org/r/65395/diff/4/ > > > Testing > ------- > > make check > > > Thanks, > > Akash Gupta > >
