----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65615/#review197703 -----------------------------------------------------------
Ship it! Ship It! - Andrew Schwartzmeyer On Feb. 16, 2018, 3:30 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65615/ > ----------------------------------------------------------- > > (Updated Feb. 16, 2018, 3:30 p.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, and > Gaston Kleiman. > > > Bugs: MESOS-8498 > https://issues.apache.org/jira/browse/MESOS-8498 > > > Repository: mesos > > > Description > ------- > > This patch is in preparation of porting docker tests to Windows. There > were a few hardcoded values that were used throughout the codebase, > such as the `alpine` image, that are defined as a constant in a single > file. > > > Diffs > ----- > > src/Makefile.am a2ba1e6de0868c7a4fe58304ec479dce039bc288 > src/tests/containerizer/docker_common.hpp PRE-CREATION > src/tests/containerizer/docker_containerizer_tests.cpp > d1e657050d623ad0412208b3aa3e3101e3654e99 > src/tests/health_check_tests.cpp 1893c85169f5e94e164434b93e6a24268224225d > src/tests/mesos.hpp f088cfdd490054ec605e33bd8c361a9d0939e22d > > > Diff: https://reviews.apache.org/r/65615/diff/2/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >