----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65713/ -----------------------------------------------------------
Review request for mesos, Alexander Rukletsov, Gilbert Song, and Greg Mann. Bugs: MESOS-8574 https://issues.apache.org/jira/browse/MESOS-8574 Repository: mesos Description ------- Previosly, if `docker inspect` command hanged, the docker container ended up in an unkillable state. This patch adds a timeout for inspect command after receiving `killTask` analogically to `reaped` handler. In addition we've added a timeout for `docker stop` command. If docker `stop` or `inspect` command times out, we discard the related future, thus the docker library kills previously spawned docker cli subprocess. As a result, a scheduler can retry `killTask` operation to handle nasty docker bugs that lead to hanging docker cli. Diffs ----- src/docker/executor.cpp 80e2d81169f0d4303ca1ddbcef9fa87fe52601fc Diff: https://reviews.apache.org/r/65713/diff/1/ Testing ------- Thanks, Andrei Budnik