----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65936/#review198902 -----------------------------------------------------------
3rdparty/stout/tests/os/filesystem_tests.cpp Lines 269 (patched) <https://reviews.apache.org/r/65936/#comment279162> I know other tests do this too, but we should default to using `sandbox.get()` here for temporary directories (instead of `os::getcwd()`). 3rdparty/stout/tests/os/filesystem_tests.cpp Lines 273-281 (patched) <https://reviews.apache.org/r/65936/#comment279161> The alternative here is to use `os::open` to get a writable `int_fd` (both HANDLE and CRT)... but that adds a dependency to the test. I'm fine with this I think. However, you do want to wrap this instead with `SharedHandle`, so we don't have to close it at the end: ``` const SharedHandle handle(::CreateFileW(...)); ``` 3rdparty/stout/tests/os/filesystem_tests.cpp Lines 284-289 (patched) <https://reviews.apache.org/r/65936/#comment279175> Again, we could use `os::write` if we wanted to add it as a dependency of the test, so I'm okay with `::WriteFile`. 3rdparty/stout/tests/os/filesystem_tests.cpp Lines 290 (patched) <https://reviews.apache.org/r/65936/#comment279176> Nit picky: `ASSERT_EQ(written, TRUE)`. - Andrew Schwartzmeyer On March 8, 2018, 11:22 a.m., John Kordich wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65936/ > ----------------------------------------------------------- > > (Updated March 8, 2018, 11:22 a.m.) > > > Review request for mesos, Akash Gupta, Andrew Schwartzmeyer, Jeff Coffler, > and Joseph Wu. > > > Bugs: MESOS-8646 > https://issues.apache.org/jira/browse/MESOS-8646 > > > Repository: mesos > > > Description > ------- > > Changed flags to CreateFile to support Windows symlink path resolution. > > > Diffs > ----- > > 3rdparty/stout/include/stout/internal/windows/reparsepoint.hpp > 858b3c7c27e95b9cf46a7457c1aaa05a0e19188d > 3rdparty/stout/tests/os/filesystem_tests.cpp > b84f1ae17246d94947538efeaf504a2cd247f20e > > > Diff: https://reviews.apache.org/r/65936/diff/2/ > > > Testing > ------- > > I encountered a permissions error stating "The process cannot access the file > because it is being used by another process." when attempting to download > stderr/stdout from a task running on a Windows agent, or when attempting to > download the mesos agent log on a Windows agent. > > After some very helpful information from Andy and Akash, I made this change > and confirmed it fixed this issue with the task/agent logs. > > I also ran the automated tests on Windows and all tests pass. > > I did not test this on Linux, but because this file is compiled only on > Windows, it shouldn't be necessary. > > > Thanks, > > John Kordich > >
