-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/66008/
-----------------------------------------------------------
(Updated March 14, 2018, 10:57 a.m.)
Review request for mesos, Akash Gupta, Benjamin Bannier, Jeff Coffler, John
Kordich, Joseph Wu, and Michael Park.
Changes
-------
Add other bug.
Bugs: MESOS-8033 and MESOS-8658
https://issues.apache.org/jira/browse/MESOS-8033
https://issues.apache.org/jira/browse/MESOS-8658
Repository: mesos
Description
-------
We had previously been using the default sets of warnings, but now we
use the same warnings as on Autotools. This also means that we can
safely turn on the treat-warnings-as-errors (at least for the Mesos
code). However, doing so requires that we disable two common
possible-loss-of-data warnings on Windows that are not part of the
GNU/Clang default warnings.
This also replaces the use of `string(APPEND CMAKE_CXX_FLAGS)` with
the canonical command `add_compile_options` (though setting these on a
per-target basis would be even better, it's a separate issue).
Diffs
-----
cmake/CompilationConfigure.cmake efee36c1ffda096a97af23d481fc0d0903124e54
src/CMakeLists.txt 0c135034982a6a4844509cd0e9b2cc41804333ef
Diff: https://reviews.apache.org/r/66008/diff/1/
Testing
-------
Thanks,
Andrew Schwartzmeyer
