> On March 19, 2018, 10:12 a.m., Zhitao Li wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3282 (patched) > > <https://reviews.apache.org/r/66060/diff/1/?file=1975230#file1975230line3282> > > > > Is there a reason this test requires `ROOT_` filter? A lot of people do > > not run such tests by default with `make check` so we could reduce coverage.
Yeah, I am afraid that the CSI plugin needs to run as root. > On March 19, 2018, 10:12 a.m., Zhitao Li wrote: > > src/tests/storage_local_resource_provider_tests.cpp > > Lines 3604 (patched) > > <https://reviews.apache.org/r/66060/diff/1/?file=1975230#file1975230line3604> > > > > Where is this magic string `"operation"` come from? Can we define a > > local const? This is just the name of the operation, it comes from line 3600. We could make it a local const. - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66060/#review199431 ----------------------------------------------------------- On March 16, 2018, 12:58 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66060/ > ----------------------------------------------------------- > > (Updated March 16, 2018, 12:58 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Zhitao Li. > > > Bugs: MESOS-8201 > https://issues.apache.org/jira/browse/MESOS-8201 > > > Repository: mesos > > > Description > ------- > > Added end-to-end tests for operation feedback. > > > Diffs > ----- > > src/tests/storage_local_resource_provider_tests.cpp > 264d42b57fe1a8ea04c1de0a10112878c7b45d39 > > > Diff: https://reviews.apache.org/r/66060/diff/1/ > > > Testing > ------- > > The tests passed over 1000 iterations on GNU/Linux. > > > Thanks, > > Gaston Kleiman > >
