----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65679/#review199606 -----------------------------------------------------------
Fix it, then Ship it! src/tests/slave_tests.cpp Lines 5131-5132 (patched) <https://reviews.apache.org/r/65679/#comment279969> "We continue dispatching `___run()` to make sure the `CHECK()` in the continuation passes." Here and elsewhere. src/tests/slave_tests.cpp Lines 5407 (patched) <https://reviews.apache.org/r/65679/#comment279970> s/slave/the/ s/call finish/call to finish/ src/tests/slave_tests.cpp Lines 5408-5409 (patched) <https://reviews.apache.org/r/65679/#comment279971> "Otherwise, the objects we captured by reference and passed to `unmocked___run` may be destroyed in the middle of the function." - Greg Mann On March 16, 2018, 7:07 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65679/ > ----------------------------------------------------------- > > (Updated March 16, 2018, 7:07 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Greg Mann. > > > Bugs: MESOS-8611 > https://issues.apache.org/jira/browse/MESOS-8611 > > > Repository: mesos > > > Description > ------- > > Directly invoking unmock calls in the test process can potentially > cause races with the real mock slave process. It is more robust to > dispatch the unmock calls to the real mock slave process. > > Also added several mock expectations to avoid "uninteresting mock > call" test warnings. > > > Diffs > ----- > > src/tests/slave_tests.cpp f76500ebdb67f131a57a3b5aaae8c952d019e354 > > > Diff: https://reviews.apache.org/r/65679/diff/6/ > > > Testing > ------- > > `./bin/mesos-tests.sh --gtest_filter=*SlaveTest* --gtest_repeat=-1 > --gtest_break_on_failure` runs forever :) > > > Thanks, > > Meng Zhu > >
