> On April 2, 2018, 10:06 a.m., Andrew Schwartzmeyer wrote: > > 3rdparty/zookeeper-3.4.8.patch > > Line 154 (original), 154 (patched) > > <https://reviews.apache.org/r/66384/diff/1/?file=1990750#file1990750line154> > > > > Also, if this change should go upstream to ZooKeeper (looks to me like > > it should) then let's make sure it does. Their process is [pretty > > similar](https://cwiki.apache.org/confluence/display/ZOOKEEPER/HowToContribute). > > > > If you don't want to, I can upstream it. > > David Forsythe wrote: > I can add it to my todo list.
FWIW I can review/shepherd over on ZooKeeper too, though I can't commit directly (yet). Michael is pretty good about it though. - Andrew ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66384/#review200292 ----------------------------------------------------------- On March 31, 2018, 7:32 p.m., David Forsythe wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66384/ > ----------------------------------------------------------- > > (Updated March 31, 2018, 7:32 p.m.) > > > Review request for mesos and Andrew Schwartzmeyer. > > > Bugs: MESOS-4176 > https://issues.apache.org/jira/browse/MESOS-4176 > > > Repository: mesos > > > Description > ------- > > Link libm in ZooKeeper build on FreeBSD. > > > Diffs > ----- > > 3rdparty/zookeeper-3.4.8.patch 2eaa056dd5668d5842b5b59a42f83ae307d4aef0 > > > Diff: https://reviews.apache.org/r/66384/diff/1/ > > > Testing > ------- > > > Thanks, > > David Forsythe > >
