----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66412/#review200443 -----------------------------------------------------------
Patch looks great! Reviews applied: [66118, 66119, 66120, 65679, 66126, 66143, 66322, 66144, 66346, 66145, 66178, 66323, 66347, 66412] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On April 3, 2018, 10:10 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66412/ > ----------------------------------------------------------- > > (Updated April 3, 2018, 10:10 p.m.) > > > Review request for mesos and Greg Mann. > > > Repository: mesos > > > Description > ------- > > In test `KillTaskGroupBetweenRunTaskParts`, added extra > synchronization to ensure `unmocked__run` finishes before > the test tear down. > > Also updated all dispatch calls to capture by value to avoid > potential races where the arguments might be destroyed > while the dispatch call is still running. > > > Diffs > ----- > > src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 > > > Diff: https://reviews.apache.org/r/66412/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
