----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66412/#review200477 -----------------------------------------------------------
FAIL: Failed to apply the dependent review: 66126. Failed command: `python.exe .\support\apply-reviews.py -n -r 66126` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412 Relevant logs: - [apply-review-66126-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/66412/logs/apply-review-66126-stdout.log): ``` error: patch failed: src/tests/slave_tests.cpp:4181 error: src/tests/slave_tests.cpp: patch does not apply ``` - Mesos Reviewbot Windows On April 4, 2018, 7:23 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66412/ > ----------------------------------------------------------- > > (Updated April 4, 2018, 7:23 p.m.) > > > Review request for mesos and Greg Mann. > > > Repository: mesos > > > Description > ------- > > In test `KillTaskGroupBetweenRunTaskParts`, added extra > synchronization to ensure `unmocked__run` finishes before > the test tear down. Added `AWAIT` calls in other > tests that use dispatch calls to guard against potential > similar issues. > > Also updated all dispatch calls to capture by value to avoid > potential races where the arguments might be destroyed > while the dispatch call is still running. > > > Diffs > ----- > > src/tests/slave_tests.cpp 0d7d9726ee39e4c588ea5eb8a54a73fbe1249353 > > > Diff: https://reviews.apache.org/r/66412/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
