> On April 13, 2018, 12:27 a.m., Greg Mann wrote: > > include/mesos/mesos.proto > > Lines 1975 (patched) > > <https://reviews.apache.org/r/66049/diff/6/?file=1994606#file1994606line1975> > > > > Hmm I wonder if we should just use a `double` here? Does the > > `Value.Scalar` type provide some benefit? > > Chun-Hung Hsiao wrote: > From the API perspective, `double` is easier to use, but `Value.Scalar` > is more consistent with how we represesnt a disk resource. > > From the implementation perspective, I prefer `Value.Scalar` because it's > arithmetic operators will do fixed-point conversions for me so I won't forget > that.
My recommendation would be to prioritize easy-of-use in the API over ease-of-implementation when possible :) In the implementation, as long as we toss the provided double into a `Scalar::Value` before we do anything with it, I think we could get the same benefit? - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66049/#review201067 ----------------------------------------------------------- On March 28, 2018, 6:24 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66049/ > ----------------------------------------------------------- > > (Updated March 28, 2018, 6:24 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Added offer operation to grow and shrink persistent volumes. > > > Diffs > ----- > > include/mesos/mesos.proto 676f0b090cad7ebf59eb32556f17ff8b5f247907 > include/mesos/v1/mesos.proto 10d506517c9f098374ab0c8f4dcfda42e1896c95 > > > Diff: https://reviews.apache.org/r/66049/diff/6/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
