> On April 16, 2018, 5:57 p.m., Zhitao Li wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 541-542 (patched) > > <https://reviews.apache.org/r/66220/diff/4/?file=1996762#file1996762line541> > > > > Let's capture this message and test its content to make sure proper > > operation is forwarded.
I think it's OK to rely on the successful task launch to infer that the volume was created successfully. I would recommend removing this future. > On April 16, 2018, 5:57 p.m., Zhitao Li wrote: > > src/tests/persistent_volume_tests.cpp > > Lines 597-603 (patched) > > <https://reviews.apache.org/r/66220/diff/4/?file=1996762#file1996762line597> > > > > This was necessary if the operation is implemented as non-speculative, > > because master/allocator only sends out `converted` resources after > > receiving the feedback from agent. If we don't ensure this is processed, > > the offer could be subject to race condition (I think). > > > > Now that we changed the course, this may not be necessary in 1.6, but > > we'd need them again once we get to MESOS-8791. > > > > Please let me know if you think keeping it is still a bad idea. I think if the framework accepts the offer and then you immediately call `Clock::settle()`, you can still be sure that the next offer you get will contain the volume. I would recommend getting rid of the `growVolumeMessage` and `shrinkVolumeMessage` futures. - Greg ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201235 ----------------------------------------------------------- On April 11, 2018, 9:19 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66220/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 9:19 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > > > Diff: https://reviews.apache.org/r/66220/diff/4/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
