----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66220/#review201355 -----------------------------------------------------------
src/tests/persistent_volume_tests.cpp Lines 474-475 (patched) <https://reviews.apache.org/r/66220/#comment282536> I see that Benjamin recently added this line and the corresponding `AWAIT_READY` to many tests. However I don't think it is necessary here; I'll check with Benjamin to see if we can also remove it from other tests in which it is not necessary. src/tests/persistent_volume_tests.cpp Lines 502 (patched) <https://reviews.apache.org/r/66220/#comment282539> Nit: `Offer offer = offersBeforeCreate->at(0);` If this test is split into smaller ones, then you can also probable make `offer` a const ref. - Gaston Kleiman On April 11, 2018, 2:19 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66220/ > ----------------------------------------------------------- > > (Updated April 11, 2018, 2:19 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > Added test for `GROW_VOLUME` and `SHRINK_VOLUME` operations. > > > Diffs > ----- > > src/tests/persistent_volume_tests.cpp > 4edf781711d9efdb994114aeb6289b6af750b87a > > > Diff: https://reviews.apache.org/r/66220/diff/4/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
