> On April 6, 2018, 2:13 p.m., Vinod Kone wrote: > > include/mesos/v1/scheduler.hpp > > Line 50 (original), 54-55 (patched) > > <https://reviews.apache.org/r/66460/diff/2/?file=1993421#file1993421line54> > > > > Since we don't guarantee backwards compat for this library, can we just > > update the signature of `send`? > > Gaston Kleiman wrote: > Would the libmesos binary then be compatible? Or would frameworks then > have to be recompiled using this new header in order to use new libmesos > binaries? > > Greg Mann wrote: > So, it sounds like if we broke the existing scheduler library interface, > that would mean that Java frameworks using the V0->V1 adapter would need to > simultaneously upgrade their Mesos JAR and libmesos. This is probably fine, > but we're checking with some framework developers to confirm.
Updating the signature of `send` would break people who have installed schedulers from packages that don't bundle the Mesos JAR and libmesos together, e.g., people who installed Marathon/Chronos and Mesos from rpm or deb packages. - Gaston ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66460/#review200670 ----------------------------------------------------------- On April 20, 2018, 5:03 p.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66460/ > ----------------------------------------------------------- > > (Updated April 20, 2018, 5:03 p.m.) > > > Review request for mesos, Greg Mann and Vinod Kone. > > > Bugs: MESOS-8192 > https://issues.apache.org/jira/browse/MESOS-8192 > > > Repository: mesos > > > Description > ------- > > This patch adds a `call()` method to the scheduler library that allows > clients to send a `v1::scheduler::Call` to the master and receive a > `v1::scheduler::Response`. > > It is going to be used to test operation state reconciliation. > > > Diffs > ----- > > include/mesos/v1/scheduler.hpp d56e08861d5190ef66992d383dc5710d8f6ce661 > include/mesos/v1/scheduler/scheduler.proto > 25ebcfcb07cb4fb928dcfdc242bb6509c9080491 > src/java/jni/org_apache_mesos_v1_scheduler_V0Mesos.cpp > 60b17b9be74132c81532d22eba681feb899b22a3 > src/scheduler/scheduler.cpp ecef916ffd0797a13552525ff2cda0f99ca57e74 > > > Diff: https://reviews.apache.org/r/66460/diff/4/ > > > Testing > ------- > > `sudo bin/mesos-tests` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >