> On April 24, 2018, 9:05 p.m., Chun-Hung Hsiao wrote: > > src/master/validation.cpp > > Lines 2332 (patched) > > <https://reviews.apache.org/r/66050/diff/13/?file=2011231#file2011231line2332> > > > > Can you add tests for this function in > > `src/tests/master_validation_tests.cpp`? To unblock this patch, it can be > > done in a follow-up one.
Done in https://reviews.apache.org/r/66858/. - Zhitao ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review201887 ----------------------------------------------------------- On April 27, 2018, 12:24 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66050/ > ----------------------------------------------------------- > > (Updated April 27, 2018, 12:24 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > The new offer operations are implemented as speculative operations, but > we will use validation to make them non-speculative on API level so that > we can transition later without a breaking change. > > > Diffs > ----- > > src/common/protobuf_utils.cpp 78bffd8595f0e9f34e981548d8136ff94160573b > src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 > src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 > src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf > src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d > > > Diff: https://reviews.apache.org/r/66050/diff/14/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
