----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66050/#review202154 -----------------------------------------------------------
Fix it, then Ship it! Overall LGTM. src/master/master.cpp Lines 4564 (patched) <https://reviews.apache.org/r/66050/#comment283786> s/`conversins`/`conversions`/ src/master/master.cpp Lines 4564-4565 (patched) <https://reviews.apache.org/r/66050/#comment283789> Suggestion: These converted resources are not put into `_offeredResources`, so no other operation can consume them. src/master/master.cpp Lines 4912 (patched) <https://reviews.apache.org/r/66050/#comment283791> Suggestion: s/`grow_volume`/`grow volume`/ src/master/master.cpp Lines 4942-4944 (patched) <https://reviews.apache.org/r/66050/#comment283793> Suggestion: Could you make the error message consistent with https://github.com/apache/mesos/blob/master/src/master/master.cpp#L5330-L5332? src/master/master.cpp Lines 4972 (patched) <https://reviews.apache.org/r/66050/#comment283794> Suggestion: s/`shrink_volume`/`shrink volume`/ src/master/master.cpp Lines 5002-5004 (patched) <https://reviews.apache.org/r/66050/#comment283795> Suggestion: Could you make the error message consistent with https://github.com/apache/mesos/blob/master/src/master/master.cpp#L5330-L5332? src/master/validation.cpp Lines 2397 (patched) <https://reviews.apache.org/r/66050/#comment283797> Suggestion: s/`required `// for consistency. src/master/validation.cpp Lines 2456 (patched) <https://reviews.apache.org/r/66050/#comment283798> Suggestion: s/`required `// for consistency. - Chun-Hung Hsiao On April 27, 2018, 7:24 p.m., Zhitao Li wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66050/ > ----------------------------------------------------------- > > (Updated April 27, 2018, 7:24 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gaston Kleiman, and Greg Mann. > > > Bugs: MESOS-4965 > https://issues.apache.org/jira/browse/MESOS-4965 > > > Repository: mesos > > > Description > ------- > > The new offer operations are implemented as speculative operations, but > we will use validation to make them non-speculative on API level so that > we can transition later without a breaking change. > > > Diffs > ----- > > src/common/protobuf_utils.cpp 78bffd8595f0e9f34e981548d8136ff94160573b > src/common/resources_utils.cpp 9be01c1abd48264e308960f35cc7c2ee8a367518 > src/master/master.cpp c723a291ed8d219ced4492bc905ac6b52683ae47 > src/master/validation.hpp 7c129ceb929596acbb64d37025e055661277e6bf > src/master/validation.cpp ac2e1bb8771841ec59b3bdcdeffb6c6230680d4d > > > Diff: https://reviews.apache.org/r/66050/diff/14/ > > > Testing > ------- > > > Thanks, > > Zhitao Li > >
