----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66819/#review203073 -----------------------------------------------------------
src/master/metrics.hpp Lines 221 (patched) <https://reviews.apache.org/r/66819/#comment285148> Is this parameter used? - Greg Mann On May 11, 2018, 7:20 a.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66819/ > ----------------------------------------------------------- > > (Updated May 11, 2018, 7:20 a.m.) > > > Review request for mesos, Benjamin Mahler, Gaston Kleiman, Greg Mann, Jie Yu, > and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Added FrameworkMetrics struct in framework struct. > > > Diffs > ----- > > src/master/master.hpp 5ec764b5c7f96bab786084cccf20fd8a17319718 > src/master/metrics.hpp ec76dbcd1d1fa5349d62ce73fb9603e1986a776b > src/master/metrics.cpp e46ead79f3f29e285426f9d061337077f453aa45 > > > Diff: https://reviews.apache.org/r/66819/diff/4/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >