----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67194/ -----------------------------------------------------------
Review request for mesos, Benjamin Bannier and John Kordich. Repository: mesos Description ------- Previously this used `add_custom_target` on the `ExternalProject_Add` target, `${CURL_TARGET}`. Because this is phony target, it caused the copy operation to always run. By switching to `ExternalProject_Add_Step`, we can change it to depend on the build sub-step of the `ExternalProject_Add` logic, ensuring it runs immediately after cURL is built, but not again. Diffs ----- 3rdparty/CMakeLists.txt 3837a31562d48962ccf5aa72fa147fd109e58ca0 Diff: https://reviews.apache.org/r/67194/diff/1/ Testing ------- Clean built on Windows, `curl.exe` gets copied after it's built, but incremental rebuilds now say `ninja: no work to do.`. Hurrah! Thanks, Andrew Schwartzmeyer