----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67215/#review203500 -----------------------------------------------------------
3rdparty/libprocess/src/subprocess_posix.cpp Line 50 (original), 50 (patched) <https://reviews.apache.org/r/67215/#comment285791> AFAICT `pipe2(2)` is available on Linux and FreeBSD but not macOS. - James Peach On May 18, 2018, 12:36 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67215/ > ----------------------------------------------------------- > > (Updated May 18, 2018, 12:36 p.m.) > > > Review request for mesos, Jie Yu and James Peach. > > > Repository: mesos > > > Description > ------- > > Opened subprocess pipes with `O_CLOEXEC`. > > > Diffs > ----- > > 3rdparty/libprocess/src/subprocess.cpp > d7a725363251f9c54072cd7551f5598696938308 > 3rdparty/libprocess/src/subprocess_posix.cpp > 01e3272fccda6ff66e1629fb10d22d8c4967b22a > > > Diff: https://reviews.apache.org/r/67215/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
