----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67274/#review203709 -----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['67274']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274 Relevant logs: - [mesos-tests-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274/logs/mesos-tests-stdout.log): ``` [ OK ] Endpoint/SlaveEndpointTest.NoAuthorizer/2 (107 ms) [----------] 9 tests from Endpoint/SlaveEndpointTest (1008 ms total) [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/0 (31 ms) [ RUN ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 [ OK ] ContainerizerType/DefaultContainerDNSFlagTest.ValidateFlag/1 (36 ms) [----------] 2 tests from ContainerizerType/DefaultContainerDNSFlagTest (69 ms total) [----------] 1 test from IsolationFlag/CpuIsolatorTest [ RUN ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 [ OK ] IsolationFlag/CpuIsolatorTest.ROOT_UserCpuUsage/0 (792 ms) [----------] 1 test from IsolationFlag/CpuIsolatorTest (818 ms total) [----------] 1 test from IsolationFlag/MemoryIsolatorTest [ RUN ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 [ OK ] IsolationFlag/MemoryIsolatorTest.ROOT_MemUsage/0 (735 ms) [----------] 1 test from IsolationFlag/MemoryIsolatorTest (759 ms total) [----------] Global test environment tear-down [==========] 981 tests from 95 test cases ran. (467033 ms total) [ PASSED ] 980 tests. [ FAILED ] 1 test, listed below: [ FAILED ] DockerContainerizerHealthCheckTest.ROOT_DOCKER_DockerHealthStatusChange 1 FAILED TEST YOU HAVE 220 DISABLED TESTS ``` - [mesos-tests-stderr.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67274/logs/mesos-tests-stderr.log): ``` I0523 23:18:02.038859 21084 slave.cpp:3935] Shutting down framework a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-0000 I0523 23:18:02.038859 11160 master.cpp:10843] Updating the state of task 4938b9f1-de41-40d0-8afd-3cae88a1f854 of framework a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-0000 (latest state: TASK_KILLED, status update state: TASK_KILLED) I0523 23:18:02.038859 21084 slave.cpp:6656] Shutting down eI0523 23:18:01.869843 20788 exec.cpp:162] Version: 1.7.0 I0523 23:18:01.898886 17840 exec.cpp:236] Executor registered on agent a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-S0 I0523 23:18:01.902873 17908 executor.cpp:178] Received SUBSCRIBED event I0523 23:18:01.907876 17908 executor.cpp:182] Subscribed executor on windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net I0523 23:18:01.907876 17908 executor.cpp:178] Received LAUNCH event I0523 23:18:01.912873 17908 executor.cpp:665] Starting task 4938b9f1-de41-40d0-8afd-3cae88a1f854 I0523 23:18:01.993871 17908 executor.cpp:485] Running 'D:\DCOS\mesos\src\mesos-containerizer.exe launch <POSSIBLY-SENSITIVE-DATA>' I0523 23:18:02.010876 17908 executor.cpp:678] Forked command at 19564 I0523 23:18:02.041158 20736 exec.cpp:445] Executor asked to shutdown I0523 23:18:02.041841 20452 executor.cpp:178] Received SHUTDOWN event I0523 23:18:02.041841 20452 executor.cpp:781] Shutting down I0523 23:18:02.041841 20452 executor.cpp:894] Sending SIGTERM to process tree at pid 19xecutor '4938b9f1-de41-40d0-8afd-3cae88a1f854' of framework a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-0000 at executor(1)@192.10.1.5:59958 I0523 23:18:02.041158 21084 slave.cpp:929] Agent terminating W0523 23:18:02.041158 21084 slave.cpp:3931] Ignoring shutdown framework a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-0000 because it is terminating I0523 23:18:02.041158 11160 master.cpp:10942] Removing task 4938b9f1-de41-40d0-8afd-3cae88a1f854 with resources cpus(allocated: *):4; mem(allocated: *):2048; disk(allocated: *):1024; ports(allocated: *):[31000-32000] of framework a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-0000 on agent a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-S0 at slave(448)@192.10.1.5:59937 (windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) I0523 23:18:02.044842 11160 master.cpp:1293] Agent a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-S0 at slave(448)@192.10.1.5:59937 (windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) disconnected I0523 23:18:02.044842 11160 master.cpp:3303] Disconnecting agent a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-S0 at slave(448)@192.10.1.5:59937 (windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) I0523 23:18:02.044842 11160 master.cpp:3322] Deactivating agent a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-S0 at slave(448)@192.10.1.5:59937 (windows-01.enofukwu14ruplxn0gs3yzmsgf.xx.internal.cloudapp.net) I0523 23:18:02.045846 21224 hierarchical.cpp:344] Removed framework a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-0000 I0523 23:18:02.045846 21224 hierarchical.cpp:766] Agent a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-S0 deactivated I0523 23:18:02.045846 21084 containerizer.cpp:2401] Destroying container fa11e28c-7b72-4fb7-8c9e-19c17d620399 in RUNNING state I0523 23:18:02.045846 21084 containerizer.cpp:3015] Transitioning the state of container fa11e28c-7b72-4fb7-8c9e-19c17d620399 from RUNNING to DESTROYING I0523 23:18:02.046878 21084 launcher.cpp:156] Asked to destroy container fa11e28c-7b72-4fb7-8c9e-19c17d620399 I0523 23:18:02.056885 11312 containerizer.cpp:2854] Container fa11e28c-7b72-4fb7-8c9e-19c17d620399 has exited I0523 23:18:02.089880 17204 master.cpp:1135] Master terminating I0523 23:18:02.092880 15992 hierarchical.cpp:609] Removed agent a9e1cd3d-0b43-4a22-bb51-06bb1a107fc6-S0 I0523 23:18:02.523885 16808 process.cpp:940] Stopped the socket accept loop ``` - Mesos Reviewbot Windows On May 23, 2018, 10:30 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67274/ > ----------------------------------------------------------- > > (Updated May 23, 2018, 10:30 p.m.) > > > Review request for mesos, Jie Yu, Joris Van Remoortere, Michael Park, and > Neil Conway. > > > Bugs: MESOS-8945 > https://issues.apache.org/jira/browse/MESOS-8945 > > > Repository: mesos > > > Description > ------- > > Internally values of scalar resources are stored in a fixed point > representation. This can lead to (expected) precision loss. > > This patch adds master validation ensuring that framework-provided > resources have values large enough so that they are still represented as > non-zero values after conversion to the internal fixed point format. As > a side-effect we now forbid frameworks from specifying truely zero > resources amounts. > > While this patch should not change valid, intended use cases, it might > change the behavior for erroneous, already broken workflows. > > > Diffs > ----- > > src/common/validation.hpp 3f60d7ac084b5341e4f33737bff931e3c3daf404 > src/common/validation.cpp 74450df1ff0eb2a892f082c60416307ecfcd9e34 > src/master/validation.cpp 798fc7975cf0f0b8b029a33137faa1737d47df66 > src/tests/master_validation_tests.cpp > 6f2a78e394c1251016ce8ce4c0f89b35c76d6ecd > > > Diff: https://reviews.apache.org/r/67274/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
