> On April 18, 2018, 6:24 a.m., Qian Zhang wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 493-517 (patched) > > <https://reviews.apache.org/r/66562/diff/2/?file=2004051#file2004051line493> > > > > Can you use raw string literal to avoid escaping?
Considering all `mockHadoopScript` was written in this way. I would suggest follow the style for now and refactor together in a separate patch. - Gilbert ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66562/#review201417 ----------------------------------------------------------- On April 16, 2018, 10:32 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66562/ > ----------------------------------------------------------- > > (Updated April 16, 2018, 10:32 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-8794 > https://issues.apache.org/jira/browse/MESOS-8794 > > > Repository: mesos > > > Description > ------- > > Added test for local puller hdfs uri fetcher plugin. > > > Diffs > ----- > > src/tests/containerizer/provisioner_docker_tests.cpp > c664ff807583d587d94b0ab797330d5d3daf7657 > > > Diff: https://reviews.apache.org/r/66562/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >