> On April 18, 2018, 9:24 p.m., Qian Zhang wrote: > > src/tests/containerizer/provisioner_docker_tests.cpp > > Lines 493-517 (patched) > > <https://reviews.apache.org/r/66562/diff/2/?file=2004051#file2004051line493> > > > > Can you use raw string literal to avoid escaping? > > Gilbert Song wrote: > Considering all `mockHadoopScript` was written in this way. I would > suggest follow the style for now and refactor together in a separate patch.
Agree. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/66562/#review201417 ----------------------------------------------------------- On June 6, 2018, 4:43 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/66562/ > ----------------------------------------------------------- > > (Updated June 6, 2018, 4:43 p.m.) > > > Review request for mesos, Jie Yu and Qian Zhang. > > > Bugs: MESOS-8794 > https://issues.apache.org/jira/browse/MESOS-8794 > > > Repository: mesos > > > Description > ------- > > Added test for local puller hdfs uri fetcher plugin. > > > Diffs > ----- > > src/tests/containerizer/provisioner_docker_tests.cpp > 3cb1a7ed251cf22c8609b39685da2d86b2770766 > > > Diff: https://reviews.apache.org/r/66562/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Gilbert Song > >