> On June 5, 2018, 1:13 a.m., Andrew Schwartzmeyer wrote: > > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > > Line 461 (original), 486 (patched) > > <https://reviews.apache.org/r/67398/diff/2/?file=2034482#file2034482line486> > > > > wget is not usually installed by default... > > Jie Yu wrote: > That's true. One possibility is to use named pipe > https://linux.die.net/man/3/mkfifo
I changed almost all tests to use named pipes now. The exception is `ROOT_CGROUPS_INTERNET_CURL_LaunchNestedDebugCheckMntNamespace` where we do not have access to the host filesystem and still use HTTP access to a process running in the test. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67398/#review204287 ----------------------------------------------------------- On June 7, 2018, 2:40 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67398/ > ----------------------------------------------------------- > > (Updated June 7, 2018, 2:40 p.m.) > > > Review request for mesos, Gilbert Song and Jie Yu. > > > Bugs: MESOS-8917 > https://issues.apache.org/jira/browse/MESOS-8917 > > > Repository: mesos > > > Description > ------- > > Some tests of nested container functionality used pipes passed to > launched tasks to detect whether a task has actually started executing > the workload (`TASK_RUNNING` updates might be sent before the task > workload is actually started). > > Once we avoid leaking unspecified file descriptors into forked > processes, this test setup will be broken. In this patch we replace > the use of pipes for synchronization with HTTP requests to an actor > running in the tests, or wait on other observable side effects. > > > Diffs > ----- > > src/tests/check_tests.cpp d48febfca220a9633b9884963bcf5a205db7f5e5 > src/tests/containerizer/nested_mesos_containerizer_tests.cpp > 6050e6ebed87249382d56aedb6d98d3cf9812bb9 > > > Diff: https://reviews.apache.org/r/67398/diff/3/ > > > Testing > ------- > > `sudo make check` > > Tested in internal CI on a number of platforms. > > > Thanks, > > Benjamin Bannier > >