----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67398/ -----------------------------------------------------------
(Updated June 15, 2018, 3 p.m.) Review request for mesos, Gilbert Song and Jie Yu. Changes ------- Removed `Waiter`. Bugs: MESOS-8917 https://issues.apache.org/jira/browse/MESOS-8917 Repository: mesos Description ------- Some tests of nested container functionality used pipes passed to launched tasks to detect whether a task has actually started executing the workload (`TASK_RUNNING` updates might be sent before the task workload is actually started). Once we avoid leaking unspecified file descriptors into forked processes, this test setup will be broken. In this patch we replace the use of pipes for synchronization with HTTP requests to an actor running in the tests, or wait on other observable side effects. Diffs (updated) ----- src/tests/check_tests.cpp d48febfca220a9633b9884963bcf5a205db7f5e5 src/tests/containerizer/nested_mesos_containerizer_tests.cpp 6050e6ebed87249382d56aedb6d98d3cf9812bb9 Diff: https://reviews.apache.org/r/67398/diff/4/ Changes: https://reviews.apache.org/r/67398/diff/3-4/ Testing ------- `sudo make check` Tested in internal CI on a number of platforms. Thanks, Benjamin Bannier