----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67391/#review204504 -----------------------------------------------------------
3rdparty/libprocess/include/process/io.hpp Lines 29-39 (original), 29-41 (patched) <https://reviews.apache.org/r/67391/#comment287021> Should we re-use the header guard like this, or add a define to CMake? 3rdparty/libprocess/src/CMakeLists.txt Lines 86-87 (patched) <https://reviews.apache.org/r/67391/#comment287020> There shouldn't be headers in CMake source lists... I'm not sure why the others are in here either... 3rdparty/libprocess/src/CMakeLists.txt Lines 118-121 (original), 130-140 (patched) <https://reviews.apache.org/r/67391/#comment287019> I think you could just replace `,libev` with `,$<$<NOT:$<PLATFORM_ID:Windows>>:libev>` and get rid of the outside conditional. cmake/CompilationConfigure.cmake Line 87 (original), 87-92 (patched) <https://reviews.apache.org/r/67391/#comment287022> I'm sorry... I definitely remember saying I was going to do this... cmake/CompilationConfigure.cmake Line 87 (original), 87-92 (patched) <https://reviews.apache.org/r/67391/#comment287023> We should sanity check if this got defined on a non-Windows platform. - Andrew Schwartzmeyer On May 30, 2018, 11:42 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67391/ > ----------------------------------------------------------- > > (Updated May 30, 2018, 11:42 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8668 > https://issues.apache.org/jira/browse/MESOS-8668 > > > Repository: mesos > > > Description > ------- > > Added Windows IOCP backend to the build system. Now, there are two async > backends, which are libevent through `ENABLE_LIBEVENT` and the Windows > IOCP (libwinio) through `ENABLE_LIBWINIO`. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt ecb6946401d9b81c6610cf9f33dcf2caa9ff0f04 > 3rdparty/libprocess/include/process/io.hpp > cc2caf44e065bed40263f3820e95a4f7c378bb98 > 3rdparty/libprocess/src/CMakeLists.txt > cf443dffd0663ecf02b7efd6f7094175b94aae19 > cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d > > > Diff: https://reviews.apache.org/r/67391/diff/1/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
