----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67391/#review205217 -----------------------------------------------------------
Ship it! I'll probably add TODOs around a couple changes here for when we remove libevent support from Windows. 3rdparty/libprocess/src/CMakeLists.txt Lines 78-87 (patched) <https://reviews.apache.org/r/67391/#comment288161> NOTE: Right now, this adds POSIX files to Windows when libwinio is not enabled. This is so we have a staging period to test libwinio in "production" before removing libevent support. When everyone is comfortable (and perhaps also when SSL support is added on top of libwinio), the option to use libevent (and so this POSIX files) will be removed from Windows, with libwinio as the only available option (that is, mandatory). - Andrew Schwartzmeyer On June 21, 2018, 4:58 a.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67391/ > ----------------------------------------------------------- > > (Updated June 21, 2018, 4:58 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Mahler, Eric Mumau, > John Kordich, Joseph Wu, and Radhika Jandhyala. > > > Bugs: MESOS-8668 > https://issues.apache.org/jira/browse/MESOS-8668 > > > Repository: mesos > > > Description > ------- > > Added Windows IOCP backend to the build system. Now, there are two async > backends, which are libevent through `ENABLE_LIBEVENT` and the Windows > IOCP (libwinio) through `ENABLE_LIBWINIO`. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 367df4b1318167aef3aeba60a31e87eee65f7a71 > 3rdparty/libprocess/include/process/io.hpp > cc2caf44e065bed40263f3820e95a4f7c378bb98 > 3rdparty/libprocess/src/CMakeLists.txt > 619183eff6d6d301a011ab03f007410f50a0aa4f > cmake/CompilationConfigure.cmake 2f92acb3a140faa48e3639c7000be7f43020ad7d > > > Diff: https://reviews.apache.org/r/67391/diff/2/ > > > Testing > ------- > > > Thanks, > > Akash Gupta > >
