----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67600/#review204795 -----------------------------------------------------------
Ship it! Ship It! - James Peach On June 14, 2018, 8:22 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67600/ > ----------------------------------------------------------- > > (Updated June 14, 2018, 8:22 p.m.) > > > Review request for mesos, Alexander Rukletsov and James Peach. > > > Repository: mesos > > > Description > ------- > > A last change applied to the file descriptor whitelist chain removed > the default value from the new argument, and this function was not > updated. This was missed because this entire isolator and its > associated tests are not in the CMake build. > > > Diffs > ----- > > src/tests/containerizer/port_mapping_tests.cpp > 575ba4624d880cc6beb7c83228712c8b1a6d74a3 > > > Diff: https://reviews.apache.org/r/67600/diff/3/ > > > Testing > ------- > > I can't test this because `./configure --enable-network-ports-isolator` is > complaining `configure: error: libnl-3 is required for building the > network/ports isolator` but I have every libnl-3 package available on my > platform installed (the library, the dev headers, and all the interfaces). > > Version: > ``` > Package: libnl-3-200 > Architecture: amd64 > Version: 3.2.29-0ubuntu3 > ``` > > > Thanks, > > Andrew Schwartzmeyer > >
