----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67607/#review204817 -----------------------------------------------------------
Ship it! Ship It! - John Kordich On June 14, 2018, 11:20 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67607/ > ----------------------------------------------------------- > > (Updated June 14, 2018, 11:20 p.m.) > > > Review request for mesos, Benjamin Bannier, John Kordich, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Our build of libarchive was erroneously linking in the shared version > of our build of zlib, and so defined `ZLIB_DLL`, which caused warnings > when the consumers of libarchive also linked in the static version of > zlib. Instead, we can direct libarchive to use exactly the zlib > library the rest of the build is using. > > Also forwarded the C arguments to libarchive for consistency with the > rest of our dependencies. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 3c1dfcc7885693cd76331b515ca8e361bd1976d0 > > > Diff: https://reviews.apache.org/r/67607/diff/1/ > > > Testing > ------- > > Link warnings before change: > > ``` > [1/1] Linking CXX executable 3rdparty\stout\tests\stout-tests.exe > LINK : 3rdparty\stout\tests\stout-tests.exe not found or not built by the > last incremental link; performing full link > archive_static.lib(archive_read_support_format_zip.c.obj) : warning LNK4049: > locally defined symbol inflate imported > archive_static.lib(archive_read_support_filter_gzip.c.obj) : warning LNK4217: > locally defined symbol inflate imported in function gzip_filter_read > archive_static.lib(archive_read_support_format_7zip.c.obj) : warning LNK4049: > locally defined symbol inflate imported > archive_static.lib(archive_read_support_format_cab.c.obj) : warning LNK4049: > locally defined symbol inflate imported > archive_static.lib(archive_read_support_format_iso9660.c.obj) : warning > LNK4217: locally defined symbol inflate imported in function > archive_read_format_iso9660_read_header > archive_static.lib(archive_read_support_format_zip.c.obj) : warning LNK4049: > locally defined symbol inflateEnd imported > archive_static.lib(archive_read_support_filter_gzip.c.obj) : warning LNK4217: > locally defined symbol inflateEnd imported in function gzip_filter_close > archive_static.lib(archive_read_support_format_7zip.c.obj) : warning LNK4049: > locally defined symbol inflateEnd imported > archive_static.lib(archive_read_support_format_cab.c.obj) : warning LNK4049: > locally defined symbol inflateEnd imported > archive_static.lib(archive_read_support_format_iso9660.c.obj) : warning > LNK4217: locally defined symbol inflateEnd imported in function time_from_tm > archive_static.lib(archive_read_support_filter_gzip.c.obj) : warning LNK4217: > locally defined symbol crc32 imported in function consume_header > archive_static.lib(archive_read_support_format_7zip.c.obj) : warning LNK4049: > locally defined symbol crc32 imported > archive_static.lib(archive_read_support_format_rar.c.obj) : warning LNK4049: > locally defined symbol crc32 imported > archive_static.lib(archive_read_support_format_zip.c.obj) : warning LNK4049: > locally defined symbol crc32 imported > archive_static.lib(archive_read_support_filter_gzip.c.obj) : warning LNK4217: > locally defined symbol inflateInit2_ imported in function consume_header > archive_static.lib(archive_read_support_format_7zip.c.obj) : warning LNK4049: > locally defined symbol inflateInit2_ imported > archive_static.lib(archive_read_support_format_cab.c.obj) : warning LNK4049: > locally defined symbol inflateInit2_ imported > archive_static.lib(archive_read_support_format_zip.c.obj) : warning LNK4049: > locally defined symbol inflateInit2_ imported > archive_static.lib(archive_read_support_format_7zip.c.obj) : warning LNK4217: > locally defined symbol inflateReset imported in function init_decompression > archive_static.lib(archive_read_support_format_cab.c.obj) : warning LNK4049: > locally defined symbol inflateReset imported > archive_static.lib(archive_read_support_format_iso9660.c.obj) : warning > LNK4217: locally defined symbol inflateReset imported in function > archive_read_support_format_iso9660 > archive_static.lib(archive_read_support_format_zip.c.obj) : warning LNK4217: > locally defined symbol inflateReset imported in function > archive_read_format_zip_cleanup > archive_static.lib(archive_read_support_format_cab.c.obj) : warning LNK4217: > locally defined symbol inflateSetDictionary imported in function > cab_read_ahead_cfdata_deflate > archive_static.lib(archive_read_support_format_iso9660.c.obj) : warning > LNK4217: locally defined symbol inflateInit_ imported in function > zisofs_read_data > ``` > > No warnings after change. stout-tests passed. Also verified that the size of > `stout-tests.exe` remained constant, so it's not "double-linking" the library. > > > Thanks, > > Andrew Schwartzmeyer > >
