----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67738/#review205388 -----------------------------------------------------------
Ship it! Ship It! - Andrew Schwartzmeyer On June 26, 2018, 12:41 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67738/ > ----------------------------------------------------------- > > (Updated June 26, 2018, 12:41 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > Upstream follows a convention of using ALL UPERCASE letters for > package names for implementations of `FindPACKAGE.cmake`. This patch > renames our `find_package` implementations fro APR and SVN. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 1360d188e2eef6743951db005f651aac499c606c > 3rdparty/stout/cmake/FindApr.cmake > 3rdparty/stout/cmake/FindSvn.cmake > > > Diff: https://reviews.apache.org/r/67738/diff/1/ > > > Testing > ------- > > * fresh build works > * rebuild works, `ninja clean && ninja tests`, `ninja tests` > > > Thanks, > > Benjamin Bannier > >
