----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67751/#review205406 -----------------------------------------------------------
FAIL: Mesos binaries failed to build. Reviews applied: `['67751']` Failed command: `cmake.exe --build . --config Release -- /maxcpucount` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67751 Relevant logs: - [mesos-binaries-cmake-stdout.log](http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67751/logs/mesos-binaries-cmake-stdout.log): ``` "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) -> "D:\DCOS\mesos\src\master\mesos-master.vcxproj" (default target) (43) -> d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\master\mesos-master.vcxproj] "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) -> "D:\DCOS\mesos\src\launcher\mesos-executor.vcxproj" (default target) (39) -> d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\launcher\mesos-executor.vcxproj] "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) -> "D:\DCOS\mesos\src\resource_provider\storage\uri_disk_profile_adaptor.vcxproj" (default target) (46) -> d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\resource_provider\storage\uri_disk_profile_adaptor.vcxproj] "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) -> "D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (32) -> d:\dcos\mesos\mesos\3rdparty\stout\include\stout\exit.hpp(69): warning C4722: '__Exit::~__Exit': destructor never returns, potential memory leak [D:\DCOS\mesos\src\slave\mesos-agent.vcxproj] "D:\DCOS\mesos\ALL_BUILD.vcxproj" (default target) (1) -> "D:\DCOS\mesos\src\cli\mesos-cli.vcxproj" (default target) (36) -> (ClCompile target) -> d:\dcos\mesos\mesos\src\cli\mesos.cpp(17): fatal error C1083: Cannot open include file: 'unistd.h': No such file or directory [D:\DCOS\mesos\src\cli\mesos-cli.vcxproj] 506 Warning(s) 1 Error(s) Time Elapsed 00:26:33.98 ``` - Mesos Reviewbot Windows On June 26, 2018, 11:12 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67751/ > ----------------------------------------------------------- > > (Updated June 26, 2018, 11:12 p.m.) > > > Review request for mesos, Benjamin Bannier, James Peach, and Joseph Wu. > > > Bugs: MESOS-8994 > https://issues.apache.org/jira/browse/MESOS-8994 > > > Repository: mesos > > > Description > ------- > > WIP: Added missing files to CMake build. > > > Diffs > ----- > > src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5 > src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21 > src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427 > src/python/executor/CMakeLists.txt PRE-CREATION > src/python/scheduler/CMakeLists.txt PRE-CREATION > src/slave/containerizer/mesos/CMakeLists.txt > ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8 > src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132 > > > Diff: https://reviews.apache.org/r/67751/diff/1/ > > > Testing > ------- > > This does not add the `option(FOO)` yet to the configuration, not is there > logic (yet) to find the necessary libraries to enable those options. How do > we want to proceed with this? I was thinking add each `option(ENABLE_XFS)` > etc. followed by a `if (ENABLE_XFS) message(FATAL_ERROR "Please add the > necessary logic to CMake to build this and see MESOS-1234."` ... but it may > honestly take just as much time to add the `find_library` logic myself... > > > Thanks, > > Andrew Schwartzmeyer > >