-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67751/#review206272
-----------------------------------------------------------
This looks overall good to me.
This patch adds some cmake options which can be enabled on the command line,
but do suprising things (e.g., add files depending on non-existant 3rdparty
deps which also rely on unset preprocessor symbols). I'd suggest to explicitly
check that the options are not enabled. This could be a simple
if (ENABLE_PORT_MAPPING_ISOLATOR)
message(FATAL "The cmake build currently does not support the port
mapping isolator, see MESOS-XYZ")
endif ()
src/CMakeLists.txt
Lines 317 (patched)
<https://reviews.apache.org/r/67751/#comment289169>
In the autotools build this triggers a `#define ENABLE_XFS_DISK_ISOLATOR`.
src/CMakeLists.txt
Lines 339 (patched)
<https://reviews.apache.org/r/67751/#comment289170>
In the autotools build this triggers a `#define
ENABLE_NETWORK_PORTS_ISOLATOR`.
src/CMakeLists.txt
Lines 344 (patched)
<https://reviews.apache.org/r/67751/#comment289171>
In the autotools build this triggers a `#define
ENABLE_PORT_MAPPING_ISOLATOR`.
src/CMakeLists.txt
Lines 604-605 (patched)
<https://reviews.apache.org/r/67751/#comment289168>
Let's remove the comments. They add nothing on this level and would
hopefully get out of sync anyway.
src/cli/CMakeLists.txt
Lines 33-40 (patched)
<https://reviews.apache.org/r/67751/#comment289167>
Simple and reasonable!
- Benjamin Bannier
On June 27, 2018, 1:12 a.m., Andrew Schwartzmeyer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67751/
> -----------------------------------------------------------
>
> (Updated June 27, 2018, 1:12 a.m.)
>
>
> Review request for mesos, Benjamin Bannier, James Peach, and Joseph Wu.
>
>
> Bugs: MESOS-8994
> https://issues.apache.org/jira/browse/MESOS-8994
>
>
> Repository: mesos
>
>
> Description
> -------
>
> WIP: Added missing files to CMake build.
>
>
> Diffs
> -----
>
> src/CMakeLists.txt 10b0946d6f49c7e9c201bad6f9f1b41cc8460fe5
> src/Makefile.am bd94a6488c1c1cc2481b9e9edb25307ced8c0d21
> src/cli/CMakeLists.txt 7b2abf2fe14888ec1da11414189f71da972ac427
> src/python/executor/CMakeLists.txt PRE-CREATION
> src/python/scheduler/CMakeLists.txt PRE-CREATION
> src/slave/containerizer/mesos/CMakeLists.txt
> ba1f92fe7dd59c34c6dee0bc7ecf6f1b5160eee8
> src/tests/CMakeLists.txt b9c906d7e91e8e2ce3ec76f972169f9b592a6132
>
>
> Diff: https://reviews.apache.org/r/67751/diff/1/
>
>
> Testing
> -------
>
> This does not add the `option(FOO)` yet to the configuration, not is there
> logic (yet) to find the necessary libraries to enable those options. How do
> we want to proceed with this? I was thinking add each `option(ENABLE_XFS)`
> etc. followed by a `if (ENABLE_XFS) message(FATAL_ERROR "Please add the
> necessary logic to CMake to build this and see MESOS-1234."` ... but it may
> honestly take just as much time to add the `find_library` logic myself...
>
>
> Thanks,
>
> Andrew Schwartzmeyer
>
>
