----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/67987/#review206264 -----------------------------------------------------------
3rdparty/Makefile.am Lines 325 (patched) <https://reviews.apache.org/r/67987/#comment289181> Does it? It looks like `jsonify.hpp` actually adds these includes in the next review: ``` #include <rapidjson/stringbuffer.h> #include <rapidjson/writer.h> ``` 3rdparty/Makefile.am Lines 327 (patched) <https://reviews.apache.org/r/67987/#comment289160> Shouldn't the header be under `$(RAPIDJSON)/include/rapidjson/rapidjson.h`? Also, should we maybe add a comment that `rapidjson.h` doesn't include any of the other public rapidjson headers? 3rdparty/Makefile.am Lines 517 (patched) <https://reviews.apache.org/r/67987/#comment289162> What's the reason that we cannot use the same `DESTDIR=$(INSTALLDIR)` pattern as for the other entries here? If I remember correctly, `includedir` should default to `$(DESTDIR)/$(PREFIX)/include`, so I guess it's to get rid of some default prefix? In this case maybe `PREFIX=` would be a little bit more explicit and consistent. (especially since the rapidjson build is cmake-based and doesn't support setting `includedir` directly) 3rdparty/rapidjson.md Lines 11 (patched) <https://reviews.apache.org/r/67987/#comment289161> This is not really related to this review, but also came up when discussing the jemalloc patches - if we modify upstreame tarballs, should we maybe gpg-sign the result? - Benno Evers On July 20, 2018, 3:38 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/67987/ > ----------------------------------------------------------- > > (Updated July 20, 2018, 3:38 a.m.) > > > Review request for mesos, Alexander Rukletsov, Benno Evers, and James Peach. > > > Bugs: MESOS-9092 > https://issues.apache.org/jira/browse/MESOS-9092 > > > Repository: mesos > > > Description > ------- > > This includes a stripped bundle of the latest release. Stripping > is required for licensing (see rapidjson.md), but also helps reduce > the bloat in the mesos git repo. > > Also included is a readme for how to update the dependency. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt b58996d2ed7521e42d6298d174cc8c494b84eb8f > 3rdparty/Makefile.am 6123b8a0164d50f0bd771d2e5f485379811e7fcb > 3rdparty/README.md fa9a6483ca2dc4980767a2cb723d654e342e6bb8 > 3rdparty/cmake/Versions.cmake 0a897d808cd9e05ac0d1a4e1ca61b8f3538f0c4a > 3rdparty/rapidjson-1.1.0.tar.gz PRE-CREATION > 3rdparty/rapidjson.md PRE-CREATION > 3rdparty/versions.am 57792800c4b4b67dd55a316ce00480db6c253d34 > configure.ac e86c496140ee9732ad3204ef22ae8ce60cd5c079 > src/Makefile.am ecb95ef152fd37e5e83c4f6415489f4cf3959578 > > > Diff: https://reviews.apache.org/r/67987/diff/1/ > > > Testing > ------- > > Tested at the end of this chain, since this is split across > stout/libprocess/mesos. > > > Thanks, > > Benjamin Mahler > >
