----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68088/ -----------------------------------------------------------
(Updated July 30, 2018, 10:50 a.m.) Review request for mesos, Gilbert Song and Jason Lai. Changes ------- Squash both diffs. Summary (updated) ----------------- Replaced `cgroups::DESTROY_TIMEOUT` with new agent flag. Bugs: MESOS-8038 https://issues.apache.org/jira/browse/MESOS-8038 Repository: mesos Description (updated) ------- The new agent flag can be used to reconfigure how long a container destroy is allowed to take on Mesos containerizer. The default is also increased to 5 min based on suggestion from Gilbert because certain containers could have deep system calls which may not finish within previous 1 min timeout. Diffs (updated) ----- src/linux/cgroups.hpp 6a6f0e6df208bc0b0a888d132b3befd062755851 src/slave/containerizer/mesos/isolators/cgroups/cgroups.cpp 8fba6f9d335cc43a7cd0fcb51ed047ba0e7027ed src/slave/containerizer/mesos/linux_launcher.cpp 3bddcece7028745cec6623ac33dbfcaced629629 src/slave/flags.hpp eeb9708f9ec76d83b6719541f4a012544c7c0cbe src/slave/flags.cpp 58cdc0f1100fe244e5bf1036e1ccf39478d5d478 Diff: https://reviews.apache.org/r/68088/diff/2/ Changes: https://reviews.apache.org/r/68088/diff/1-2/ Testing ------- `make` and `./bin/mesos-slave.sh --help` Thanks, Zhitao Li