----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68329/#review207223 -----------------------------------------------------------
Patch looks great! Reviews applied: [68329] Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh - Mesos Reviewbot On Aug. 14, 2018, 4:04 a.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68329/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2018, 4:04 a.m.) > > > Review request for mesos, Akash Gupta, Benjamin Mahler, and Joseph Wu. > > > Bugs: MESOS-9084 > https://issues.apache.org/jira/browse/MESOS-9084 > > > Repository: mesos > > > Description > ------- > > Note that we now add `io_tests.cpp` unconditionally, which will > fail/hang with libevent. However, this is because libevent is buggy, > and should not be used. We would prefer the tests not pass with > libevent enabled, rather than appear to pass because the failing tests > are excluded, giving the false impression that it works correctly. > > > Diffs > ----- > > 3rdparty/libprocess/src/CMakeLists.txt > 19fa9809c2298ea68649702b94a0c75d806caba3 > 3rdparty/libprocess/src/tests/CMakeLists.txt > a03a77eb5e289b4daac0bbd414dc17c8acc848dc > > > Diff: https://reviews.apache.org/r/68329/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
