> On Aug. 15, 2018, 12:04 a.m., Chun-Hung Hsiao wrote: > > I'm not sure if we want to have this. If we are to follow the same pattern > > as `MARK_AGENT_GONE`, shouldn't the manager just disconnects the resource > > provider and prevents future registration? > > Benjamin Bannier wrote: > Removed from the MESOS-8403 chain.
Actually I changed my mind lol. I went through the master code again and now feel we probably still want to have such a message. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/#review207279 ----------------------------------------------------------- On Aug. 1, 2018, 3:47 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68145/ > ----------------------------------------------------------- > > (Updated Aug. 1, 2018, 3:47 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > In order to allow proper cleanup the resource provider manager sends a > `REMOVED` to a resource provider when it is being removed. > > The event is not sent reliably, i.e., if the resource provider was > e.g., not subscribed when it was removed we currently will never > attempt to resend the event. > > > Diffs > ----- > > include/mesos/resource_provider/resource_provider.proto > 7c6833378401751a8997ecd3279cf3bf2ad3cbf4 > include/mesos/v1/resource_provider/resource_provider.proto > 535b898b03cd3d81261d62523916cf9a6410a30d > src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620 > src/resource_provider/storage/provider.cpp > 22c184f45ea43335c3e1e4598f7409a4f05fb38e > src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8 > > > Diff: https://reviews.apache.org/r/68145/diff/3/ > > > Testing > ------- > > `make check` > > Additional testing with the test case added in > https://reviews.apache.org/r/68147/. > > > Thanks, > > Benjamin Bannier > >
