----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68145/#review207454 -----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['68143', '68144', '68146', '68147', '68362', '68145']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2175/mesos-review-68145 Relevant logs: - [mesos-tests.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2175/mesos-review-68145/logs/mesos-tests.log): ``` I0816 23:47:42.137460 5088 manager.cpp:161] Terminating resource provider f32541e2-ed3b-4108-a7b3-c29e5125e3a0 I0816 23:47:42.138466 20644 slave.cpp:7636] Handling resource provider message 'SUBSCRIBE: {"id":{"value":"f32541e2-ed3b-4108-a7b3-c29e5125e3a0"},"name":"test","type":"org.apache.mesos.rp.test"}' E0816 23:47:42.139451 20644 http_connection.hpp:452] End-Of-File received I0816 23:47:42.140449 5892 slave.cpp:7636] Handling resource provider message 'DISCONNECT: resource provider f32541e2-ed3b-4108-a7b3-c29e5125e3a0' I0816 23:47:42.140449 5892 slave.cpp:7884] Forwarding new total resources cpus:4; mem:2048; disk:1024; ports:[31000-32000] I0816 23:47:42.140449 20644 http_connection.hpp:217] Re-detecting endpoint [libprotobuf FATAL d:\dcos\mesos\3rdparty\protobuf-3.5.0\src\protobuf-3.5.0\src\google\protobuf\message_lite.cc:281] CHECK failed: IsInitialized(): Can't serialize message of type "mesos.internal.UpdateSlaveMessage" because it is missing required fields: resource_providers.providers[0].resource_version_uuid.value *** Check failure stack trace: *** @ 00007FF7C6FD45BB google::LogMessage::Fail @ 00007FF7C6FD44C1 google::LogMessage::SendToLog @ 00007FF7C6FD3CA7 google::LogMessage::Flush @ 00007FF7C6FD57E1 google::LogMessageFatal::~LogMessageFatal @ 00007FF7C87CE897 `process::ProcessManager::resume'::`1'::catch$11 @ 00007FFA1BA414F0 __C_specific_handler @ 00007FFA1BA4536A __BuildCatchObjectHelper @ 00007FFA2A14E273 RtlCaptureContext @ 00007FF7C6AC1B70 process::ProcessManager::resume @ 00007FF7C6BF4CD1 ?? @ 00007FF7C6B14480 std::_Invoker_functor::_Call<<lambda_124422ac022fa041208b80c1460630d7> > @ 00007FF7C6B76280 std::invoke<<lambda_124422ac022fa041208b80c1460630d7> > @ 00007FF7C6B2A07C std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Execute<0> @ 00007FF7C6C4A88A std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Run @ 00007FF7C6C35E78 std::_LaunchPad<std::unique_ptr<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> >,std::default_delete<std::tuple<<lambda_124422ac022fa041208b80c1460630d7> > > > >::_Go @ 00007FF7C6C1B9AD std::_Pad::_Call_func @ 00007FFA11123428 _register_onexit_function @ 00007FFA11123071 _register_onexit_function @ 00007FFA275E3034 BaseThreadInitThunk @ 00007FFA2A121431 RtlUserThreadStart F0816 23:47:42.142452 5892 process.cpp:2990] Aborting libprocess: 'slave(95)@192.10.1.10:53477' threw exception: CHECK failed: IsInitialized(): Can't serialize message of type "mesos.internal.UpdateSlaveMessage" because it is missing required fields: resource_providers.providers[0].resource_version_uuid.value ``` - Mesos Reviewbot Windows On Aug. 16, 2018, 2:30 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68145/ > ----------------------------------------------------------- > > (Updated Aug. 16, 2018, 2:30 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jan Schlicht. > > > Bugs: MESOS-8403 > https://issues.apache.org/jira/browse/MESOS-8403 > > > Repository: mesos > > > Description > ------- > > In order to allow proper cleanup the resource provider manager sends a > `REMOVED` to a resource provider when it is being removed. > > The event is not sent reliably, i.e., if the resource provider was > e.g., not subscribed when it was removed we currently will never > attempt to resend the event. > > > Diffs > ----- > > include/mesos/resource_provider/resource_provider.proto > 7c6833378401751a8997ecd3279cf3bf2ad3cbf4 > include/mesos/v1/resource_provider/resource_provider.proto > 535b898b03cd3d81261d62523916cf9a6410a30d > src/resource_provider/manager.cpp abd7e38e5517ea600f9fc9b8a96c7d0d26df0620 > src/resource_provider/storage/provider.cpp > 22c184f45ea43335c3e1e4598f7409a4f05fb38e > src/tests/mesos.hpp 75c5fae8ed30f64c973b1cc290f8540a072cb8a8 > > > Diff: https://reviews.apache.org/r/68145/diff/5/ > > > Testing > ------- > > `make check` > > Additional testing with the test case added in > https://reviews.apache.org/r/68147/. > > > Thanks, > > Benjamin Bannier > >