----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68343/#review207410 -----------------------------------------------------------
src/master/http.cpp Lines 2876-2878 (patched) <https://reviews.apache.org/r/68343/#comment290800> Let's maybe make it a method in a to-be-introduced `Master::Http::ReadOnlyHandler` class. This way you hide the `const Master*` inside the `ReadOnlyHandler` instance and keep the endpoint handler geographically closer to other handler code. - Alexander Rukletsov On Aug. 14, 2018, 2:20 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68343/ > ----------------------------------------------------------- > > (Updated Aug. 14, 2018, 2:20 p.m.) > > > Review request for mesos and Alexander Rukletsov. > > > Repository: mesos > > > Description > ------- > > In preparation for the changes in the subsequent commit, > the serialization logic was moved from an inner lambda > to a separate function. > > > Diffs > ----- > > src/master/http.cpp e2773ed78d3d07da13029a4d75143f062d97c852 > src/master/master.hpp 85ef14c1cc72180b746a5f4375769b653cbe511d > > > Diff: https://reviews.apache.org/r/68343/diff/1/ > > > Testing > ------- > > > Thanks, > > Benno Evers > >
