----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68366/#review207524 -----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs. Reviews applied: `['68366']` Failed command: `Start-MesosCITesting` All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2185/mesos-review-68366 Relevant logs: - [mesos-tests-cmake.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2185/mesos-review-68366/logs/mesos-tests-cmake.log): ``` d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\zookeeper.c(3479): warning C4101: 'addrstr': unreferenced local variable [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj] "D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) -> "D:\DCOS\mesos\src\slave\mesos-agent.vcxproj" (default target) (11) -> (ClCompile target) -> d:\dcos\mesos\mesos\src\slave\main.cpp(322): error C2039: 'check_agent_port_range_only': is not a member of 'mesos::internal::slave::Flags' [D:\DCOS\mesos\src\slave\mesos-agent.vcxproj] d:\dcos\mesos\mesos\src\slave\main.cpp(323): error C2039: 'container_ports_protected_range': is not a member of 'mesos::internal::slave::Flags' [D:\DCOS\mesos\src\slave\mesos-agent.vcxproj] d:\dcos\mesos\mesos\src\slave\main.cpp(323): error C2228: left of '.isSome' must have class/struct/union [D:\DCOS\mesos\src\slave\mesos-agent.vcxproj] 172 Warning(s) 3 Error(s) Time Elapsed 00:18:23.87 ``` - Mesos Reviewbot Windows On Aug. 17, 2018, 5:21 p.m., Xudong Ni wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68366/ > ----------------------------------------------------------- > > (Updated Aug. 17, 2018, 5:21 p.m.) > > > Review request for mesos and James Peach. > > > Bugs: MESOS-9133 > https://issues.apache.org/jira/browse/MESOS-9133 > > > Repository: mesos > > > Description > ------- > > For a network isolator disabled environment, in practice, there could > be a lot of users already binding to ephemeral ports; It would take > a lot of efforts to find/notify/modify those apps; In order to take > advantage of network isolator and enable it in such system, it would > be useful to add mesos-agent configuration option to allow enforce > port isolation in only the specified certain port range > > > Diffs > ----- > > docs/configuration/agent.md 4e50b681bb956d559da6bf1d2c504099aae3cafb > docs/isolators/network-ports.md 5d14fc2985e099783b09e2a19f99641b4ddbd768 > src/slave/containerizer/mesos/isolators/network/ports.hpp > 6944d01e0f8a11eda381ef1754f19ee0cf9359c8 > src/slave/containerizer/mesos/isolators/network/ports.cpp > 2a7ff2530f898cf892739c715b07b3387b423ed9 > src/slave/flags.hpp 88c35da5fd754abbd4bd316e1fa9efa4a70a6b8c > src/slave/flags.cpp 54d9acc8693f53294bdc2a88183cac84a8dfbfd9 > src/slave/main.cpp 489e87522588be259d382f588b66907ba29f1788 > src/tests/containerizer/ports_isolator_tests.cpp > db080c4e9c8b0c036294a8f7a42617ca1231f884 > > > Diff: https://reviews.apache.org/r/68366/diff/3/ > > > Testing > ------- > > New test added to test feature: > [ OK ] NetworkPortsIsolatorTest.ROOT_NC_PortEnforcementProtectedPort > (1812 ms) > [----------] 1 test from NetworkPortsIsolatorTest (1813 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1826 ms total) > [ PASSED ] 1 test. > > Existing test updated to test the negative cases: > > [ RUN ] NetworkPortsIsolatorTest.ROOT_IsolatorFlags > [ OK ] NetworkPortsIsolatorTest.ROOT_IsolatorFlags (69 ms) > [----------] 1 test from NetworkPortsIsolatorTest (70 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (82 ms total) > [ PASSED ] 1 test. > > Existing test for isolator feature: > > [ OK ] NetworkPortsIsolatorTest.ROOT_NC_AllocatedPorts (1821 ms) > [----------] 1 test from NetworkPortsIsolatorTest (1822 ms total) > > [----------] Global test environment tear-down > [==========] 1 test from 1 test case ran. (1836 ms total) > [ PASSED ] 1 test. > > > Thanks, > > Xudong Ni > >
