> On Sept. 11, 2018, 11:25 p.m., James Peach wrote: > > 3rdparty/libprocess/configure.ac > > Lines 805 (patched) > > <https://reviews.apache.org/r/68641/diff/1/?file=2082802#file2082802line805> > > > > Maybe: > > ``` > > test "x$without_bundled_libevent" = "xyes" -o "x$enable_bundled" != > > "xyes" > > ```
I did that initally but abandoned that approach as we generally seem to go for explicit instead of the test specific combinatorics. In the interest of consistency, I shall leave as is for now, ok? :) See e.g. a few lines above; ``` if test -z "`echo $with_libevent`" && test "$OS_NAME" = "darwin" && test -n "`command -v brew`" && test -n "`brew list --versions libevent`"; then with_libevent=`brew --prefix libevent` fi ``` > On Sept. 11, 2018, 11:25 p.m., James Peach wrote: > > 3rdparty/libprocess/configure.ac > > Lines 1144 (patched) > > <https://reviews.apache.org/r/68641/diff/1/?file=2082802#file2082802line1144> > > > > Just a nit, I would find this more readable: > > ``` > > if test "x$enable_libevent" = "xyes" -a "x$with_bundled_libevent" != > > "xyes" ; then > > ... > > fi > > ``` See above - let's do that everywhere in a cleansweep. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68641/#review208536 ----------------------------------------------------------- On Sept. 16, 2018, 8:41 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68641/ > ----------------------------------------------------------- > > (Updated Sept. 16, 2018, 8:41 p.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and James Peach. > > > Bugs: MESOS-7076 > https://issues.apache.org/jira/browse/MESOS-7076 > > > Repository: mesos > > > Description > ------- > > Added version check and bundling of libevent within libprocess. > > > Diffs > ----- > > 3rdparty/libprocess/Makefile.am f9d9d0609f5c8fed419be83319319e67afc063b7 > 3rdparty/libprocess/configure.ac e9e2434b7b6fe6c94c28744a86f9412b6302cbe0 > > > Diff: https://reviews.apache.org/r/68641/diff/2/ > > > Testing > ------- > > Manual testing on macOS 10.14 as well as Ubuntu 18.04LTS. Additional testing > is ongoing. CMake updates will follow. > > > Thanks, > > Till Toenshoff > >
