> On Sept. 21, 2018, 3:57 p.m., James Peach wrote: > > configure.ac > > Line 1491 (original), 1491 (patched) > > <https://reviews.apache.org/r/68640/diff/3/?file=2089807#file2089807line1491> > > > > Minor nit, this could be: > > > > ``` > > test "x$without_bundled_libevent" = "xyes" -o "x$enable_bundled" != > > "xyes" > > ```
We generally do not use the `test` combinatoric options so far. > On Sept. 21, 2018, 3:57 p.m., James Peach wrote: > > m4/libevent.m4 > > Lines 42 (patched) > > <https://reviews.apache.org/r/68640/diff/3/?file=2089808#file2089808line42> > > > > Since these checks always error out, I think it would be easier to read > > if you just make them sequentially rather than nesting them. > > > > For example: > > ``` > > AC_CHECK_HEADERS([event2/event.h], ...) > > AC_CHECK_LIB([event], [event_base_new], ...) > > > > etc. > > ``` > > > > Since this is just extracted from the previous chec, just a suggestion. > > Refactor if you like :) Yeah, much better read then - thanks for pointing it out! > On Sept. 21, 2018, 3:57 p.m., James Peach wrote: > > m4/libevent.m4 > > Lines 94 (patched) > > <https://reviews.apache.org/r/68640/diff/3/?file=2089808#file2089808line94> > > > > Use `AS_IF` consistently here? Thanks! - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/#review208863 ----------------------------------------------------------- On Sept. 22, 2018, 7:53 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68640/ > ----------------------------------------------------------- > > (Updated Sept. 22, 2018, 7:53 p.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and James Peach. > > > Bugs: MESOS-7076 > https://issues.apache.org/jira/browse/MESOS-7076 > > > Repository: mesos > > > Description > ------- > > Bundles libevent 2.0.22 to ensure functional SSL builds accross all > supported platforms. Namely macOS and Ubuntu have shown problems when > using more recent libevent versions. The underlying problem has been > under investigation for a longer period of time - so far without a > solution. The bundled libevent includes a patch to make it libssl > version > 1.0.x compatible. That patch has been extracted from the > Fedora source package libevent-2.0.22-6.fc27. The resulting libevent > builds against both, libssl 1.0.x as well as libssl 1.1.x. > For unbundled builds a version detection of known problematic > distributions vs. provided libevent is included. > > > Diffs > ----- > > 3rdparty/Makefile.am a6709ff9c7ef81896174ed4d35e1b1da9bb33757 > 3rdparty/libevent-2.0.22-stable.patch PRE-CREATION > 3rdparty/libevent-2.0.22-stable.tar.gz PRE-CREATION > 3rdparty/versions.am 8fd8bd4d7482af5304ab0b56270e49f447e0b3f5 > configure.ac 472e1102bf049e62beaacc9ccb231b6cf11c5fe5 > m4/libevent.m4 PRE-CREATION > > > Diff: https://reviews.apache.org/r/68640/diff/4/ > > > Testing > ------- > > Manual testing on macOS 10.14 as well as Ubuntu 18.04LTS. CMake updates will > follow soon. > > > Thanks, > > Till Toenshoff > >
