----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68640/ -----------------------------------------------------------
(Updated Sept. 16, 2018, 8:40 p.m.) Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, and James Peach. Changes ------- Addressed comments - thanks for the reviews James! Summary (updated) ----------------- Added version check and bundling of libevent to autotools. Bugs: MESOS-7076 https://issues.apache.org/jira/browse/MESOS-7076 Repository: mesos Description ------- Bundles libevent 2.0.22 to ensure functional SSL builds accross all supported platforms. Namely macOS and Ubuntu have shown problems when using more recent libevent versions. The underlying problem has been under investigation for a longer period of time - so far without a solution. The bundled libevent includes a patch to make it libssl version > 1.0.x compatible. That patch has been extracted from the Fedora source package libevent-2.0.22-6.fc27. The resulting libevent builds against both, libssl 1.0.x as well as libssl 1.1.x. For unbundled builds a version detection of known problematic distributions vs. provided libevent is included. Diffs (updated) ----- 3rdparty/Makefile.am a6709ff9c7ef81896174ed4d35e1b1da9bb33757 3rdparty/libevent-2.0.22-stable.patch PRE-CREATION 3rdparty/libevent-2.0.22-stable.tar.gz PRE-CREATION 3rdparty/versions.am 8fd8bd4d7482af5304ab0b56270e49f447e0b3f5 configure.ac 472e1102bf049e62beaacc9ccb231b6cf11c5fe5 m4/libevent.m4 PRE-CREATION Diff: https://reviews.apache.org/r/68640/diff/3/ Changes: https://reviews.apache.org/r/68640/diff/2-3/ Testing (updated) ------- Manual testing on macOS 10.14 as well as Ubuntu 18.04LTS. CMake updates will follow soon. Thanks, Till Toenshoff