> On Sept. 26, 2018, 9:48 p.m., Benjamin Bannier wrote: > > src/python/native_common/ext_modules.py.in > > Lines 121-126 (patched) > > <https://reviews.apache.org/r/68856/diff/1/?file=2092349#file2092349line121> > > > > This is inconsistent in checking whether files exist, and also > > duplicates complicated paths in multiple, hard to compare places. > > > > I would suggest to instead e.g., create a list of object files > > ``` > > objs = ['libevent.a', 'libevent_extra.a', 'libevent_pthreads.a'] > > > > if '@ENABLE_SSL_TRUE@' == '': > > objs.append('libevent_openssl.a') > > ``` > > > > and then add them should they exist > > ``` > > for obj in objs: > > obj = os.path.join(abs_top_builddir, libevent_dir, '.libs', obj) > > if os.path.exists(obj): > > EXTRA_OBJECTS.append(obj) > > ``` > > > > or something similar.
While I agree that this looks inconsistent, one needs to keep in mind that the file-exist check is purely for finding out if we use a bundled version or not. If the bundled version was intended, then we would not even get here if the artefacts were not all there. So checking for a single one is sufficient. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/#review209048 ----------------------------------------------------------- On Sept. 26, 2018, 9:32 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68856/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2018, 9:32 p.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, and James Peach. > > > Repository: mesos > > > Description > ------- > > Added missing python egg build extensions for libevent. > > > Diffs > ----- > > src/python/native_common/ext_modules.py.in > 7efbb8ec91b74c32ac629f1f2e7de82986d518db > > > Diff: https://reviews.apache.org/r/68856/diff/1/ > > > Testing > ------- > > CI and make check > > > Thanks, > > Till Toenshoff > >
