> On Sept. 26, 2018, 10:06 p.m., Benjamin Bannier wrote: > > src/python/native_common/ext_modules.py.in > > Lines 121-126 (patched) > > <https://reviews.apache.org/r/68856/diff/1/?file=2092349#file2092349line121> > > > > As discussed offline, I misunderstood part of the intention here. We > > exclusively check for `libevent` to detect whether this is a bundled build > > or not, but otherwise assert that for bundled libevent all required files > > exist. With that it makes less sense to enforce existance of all files. > > > > I am dropping this issue, but it would probably still make sense to > > pull `os.path.join(abs_top_builddir, libevent_dir, '.libs')` into a > > variable, e.g., `libevent_dir`.
Agree - thanks for your swift review - MUCH appreciated. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68856/#review209052 ----------------------------------------------------------- On Sept. 26, 2018, 9:32 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68856/ > ----------------------------------------------------------- > > (Updated Sept. 26, 2018, 9:32 p.m.) > > > Review request for mesos, Benjamin Bannier, Benno Evers, and James Peach. > > > Repository: mesos > > > Description > ------- > > Added missing python egg build extensions for libevent. > > > Diffs > ----- > > src/python/native_common/ext_modules.py.in > 7efbb8ec91b74c32ac629f1f2e7de82986d518db > > > Diff: https://reviews.apache.org/r/68856/diff/1/ > > > Testing > ------- > > CI and make check > > > Thanks, > > Till Toenshoff > >
