----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/68956/#review209464 -----------------------------------------------------------
Since the propagating the new flag affects both this change and the change in the previous patch, I think we should cbombine those w. src/master/allocator/mesos/metrics.hpp Line 97 (original), 97 (patched) <https://reviews.apache.org/r/68956/#comment293888> This should format like: ```C FrameworkMetrics( const FrameworkInfo& _frameworkInfo, bool _enable); ``` Note 4-space indent, and you can drop the `explicit` because you added the 2nd parameter. Same indent in the other source files. src/master/allocator/mesos/metrics.hpp Lines 113 (patched) <https://reviews.apache.org/r/68956/#comment293905> Should be "enabled" src/master/allocator/mesos/metrics.cpp Lines 221 (patched) <https://reviews.apache.org/r/68956/#comment293906> Let's use the same approach as in the previous patch. src/master/flags.cpp Lines 688 (patched) <https://reviews.apache.org/r/68956/#comment293907> s/collected/published/ - James Peach On Oct. 10, 2018, 10:19 p.m., Jacob Janco wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/68956/ > ----------------------------------------------------------- > > (Updated Oct. 10, 2018, 10:19 p.m.) > > > Review request for mesos, Benjamin Mahler, Greg Mann, and James Peach. > > > Bugs: MESOS-9301 > https://issues.apache.org/jira/browse/MESOS-9301 > > > Repository: mesos > > > Description > ------- > > In clusters with high numbers of frameworks, it is > necessary to control the registration of per > framework metrics. > > > Diffs > ----- > > include/mesos/allocator/allocator.hpp > 61b2b843a10fd73bf876a86e9e18b2d78b70f9b1 > src/master/allocator/mesos/hierarchical.hpp > e09a615979014909e7b88d44e6617fd1476415c5 > src/master/allocator/mesos/hierarchical.cpp > 6f389ed46683f7c642e87b673dc15307cc2b5cd6 > src/master/allocator/mesos/metrics.hpp > 34cc16b3a4e0622d8ab1c39b093e58e9a37702c0 > src/master/allocator/mesos/metrics.cpp > 73e68eb4ef53b56f2a764b0504e92d4688eb183c > src/master/flags.hpp 4a260155b32fada4ba7a6ae6de7aaecaa25839ff > src/master/flags.cpp 6ad53ed44d82e25c05548135b8f152d45ebf6629 > src/master/framework.cpp 7cfe9f49cb407655984bdee16f7567576d553711 > src/master/master.hpp ea7e9242b62fe6c2cc0e717f9a9f2f0c1cc0a390 > src/master/master.cpp 06d769aeba16586a020729d454f4d00688b78c78 > src/master/metrics.hpp e1da18e6ba2737f729e1e30653020538150ae898 > src/master/metrics.cpp 56a7eef2d279ad3248092d37d19013d3ac110757 > > > Diff: https://reviews.apache.org/r/68956/diff/2/ > > > Testing > ------- > > make check on OSX > > test-framework in local cluster with flag on/off > > > Thanks, > > Jacob Janco > >
