----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209953 -----------------------------------------------------------
3rdparty/CMakeLists.txt Line 998 (original), 998 (patched) <https://reviews.apache.org/r/69140/#comment294604> Am a bit unsure about this specific change and would appreciate a windows-feedback :) - Till Toenshoff On Oct. 24, 2018, 12:25 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69140/ > ----------------------------------------------------------- > > (Updated Oct. 24, 2018, 12:25 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, James > Peach, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Allowed for unbundled libarchive on cmake builds. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 9584f537cc2a862ce17037224fd0628ffda54b2b > 3rdparty/cmake/FindLIBARCHIVE.cmake PRE-CREATION > cmake/CompilationConfigure.cmake 5d2be0adc55ac5302c2e0e62131feb65657466be > > > Diff: https://reviews.apache.org/r/69140/diff/1/ > > > Testing > ------- > > cmake .. -DUNBUNDLED_LIBARCHIVE=ON > cmake .. -DUNBUNDLED_LIBARCHIVE=OFF > cmake .. -DUNBUNDLED_LIBARCHIVE=ON > -DLIBARCHIVE_ROOT_DIR=/usr/local/opt/libarchive > cmake .. > > > Thanks, > > Till Toenshoff > >