> On Oct. 24, 2018, 6:21 p.m., Joseph Wu wrote: > > 3rdparty/cmake/FindLIBARCHIVE.cmake > > Lines 21-24 (patched) > > <https://reviews.apache.org/r/69140/diff/1/?file=2102144#file2102144line21> > > > > Prefix this with: > > ``` > > # NOTE: If this fails, stderr is ignored, and the output variable is > > empty. > > # This has no deleterious effect on our path search. > > ``` > > To note that non-OSX builds are unaffected by this command not existing.
We should also do the same then for the FindLIBEVENT.cmake part. .... noted ... > On Oct. 24, 2018, 6:21 p.m., Joseph Wu wrote: > > cmake/CompilationConfigure.cmake > > Lines 82-84 (patched) > > <https://reviews.apache.org/r/69140/diff/1/?file=2102145#file2102145line82> > > > > The `LIBARCHIVE_ROOT_DIR` variable doesn't need to be inside this > > conditional. The variable would have no effect when we are using a bundled > > library, and would still be set/read on using an installed library. True, I followed the template of libEVENT here as well - we should adapt that one then as well... NOTED.... - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69140/#review209976 ----------------------------------------------------------- On Oct. 30, 2018, 8:20 p.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69140/ > ----------------------------------------------------------- > > (Updated Oct. 30, 2018, 8:20 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Benjamin Bannier, James > Peach, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Allowed for unbundled libarchive on cmake builds. > > > Diffs > ----- > > 3rdparty/CMakeLists.txt 9584f537cc2a862ce17037224fd0628ffda54b2b > 3rdparty/cmake/FindLIBARCHIVE.cmake PRE-CREATION > cmake/CompilationConfigure.cmake 5d2be0adc55ac5302c2e0e62131feb65657466be > > > Diff: https://reviews.apache.org/r/69140/diff/2/ > > > Testing > ------- > > cmake .. -DUNBUNDLED_LIBARCHIVE=ON > cmake .. -DUNBUNDLED_LIBARCHIVE=OFF > cmake .. -DUNBUNDLED_LIBARCHIVE=ON > -DLIBARCHIVE_ROOT_DIR=/usr/local/opt/libarchive > cmake .. > > > Thanks, > > Till Toenshoff > >
