----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69369/#review210624 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.hpp Lines 2362 (patched) <https://reviews.apache.org/r/69369/#comment295358> Please include <algorithm> - Alexander Rukletsov On Nov. 18, 2018, 1:25 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/69369/ > ----------------------------------------------------------- > > (Updated Nov. 18, 2018, 1:25 a.m.) > > > Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin > Bannier. > > > Bugs: MESOS-9317 > https://issues.apache.org/jira/browse/MESOS-9317 > > > Repository: mesos > > > Description > ------- > > Adds the helper function 'collectAuthorizations' to master.hpp. This > function allows for a simple way to collect authorization futures and > only if all supplied futures result in an approved authorization will > the returned future return true. > > All identified areas that were formally triggering MESOS-9317 are > being updated to make use of this new helper. > > A helper function has been chosen and preferred over copying this > pattern into the areas that needed a fix to allow for an efficient and > complete test coverage. > > Additionally we are adding a test validating that new helper. > > > Diffs > ----- > > src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff > src/master/master.cpp 1e326ec42a7f79a0835529a4655e7ec272f1cf40 > src/master/weights_handler.cpp 222ec754e216da195250d1895a728294a076ee5d > src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 > > > Diff: https://reviews.apache.org/r/69369/diff/2/ > > > Testing > ------- > > `make check` and internal CI validation. > > > Thanks, > > Till Toenshoff > >
