----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/69369/ -----------------------------------------------------------
(Updated Nov. 18, 2018, 10:49 p.m.) Review request for mesos, Alexander Rukletsov, Alexander Rojas, and Benjamin Bannier. Changes ------- Added missing include. Bugs: MESOS-9317 https://issues.apache.org/jira/browse/MESOS-9317 Repository: mesos Description ------- Adds the helper function 'collectAuthorizations' to master.hpp. This function allows for a simple way to collect authorization futures and only if all supplied futures result in an approved authorization will the returned future return true. All identified areas that were formally triggering MESOS-9317 are being updated to make use of this new helper. A helper function has been chosen and preferred over copying this pattern into the areas that needed a fix to allow for an efficient and complete test coverage. Additionally we are adding a test validating that new helper. Diffs (updated) ----- src/master/master.hpp e77babf22126838c63cd05e483875c9beb3ac5ff src/master/master.cpp 9458ff10999d48e40a8596ec4edf1243591bc0d4 src/master/weights_handler.cpp 222ec754e216da195250d1895a728294a076ee5d src/tests/master_tests.cpp ac6bf379c5906cf9612284911c121c9457f648a0 Diff: https://reviews.apache.org/r/69369/diff/3/ Changes: https://reviews.apache.org/r/69369/diff/2-3/ Testing ------- `make check` and internal CI validation. Thanks, Till Toenshoff